Skip to content

[TEST ONLY] #9787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

[TEST ONLY] #9787

wants to merge 6 commits into from

Conversation

kirklandsign
Copy link
Contributor

No description provided.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Mar 31, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9787

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit ca4646e with merge base 771588a (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 31, 2025
@kirklandsign kirklandsign changed the base branch from main to release/0.6 March 31, 2025 23:42
@github-actions GitHub Actions
Copy link

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@kirklandsign
Copy link
Contributor Author

Hi @huydhn I am just wondering, seems that the secret is empty string here. Do you have any ideas?

huydhn
huydhn reviewed Apr 7, 2025
View reviewed changes
.github/workflows/android-release-artifacts.yml
@@ -36,6 +36,7 @@ jobs:
id-token: write
contents: read
with:
secrets-env: EXECUTORCH_MAVEN_SIGNING_KEYID EXECUTORCH_MAVEN_SIGNING_PASSWORD EXECUTORCH_MAVEN_CENTRAL_PASSWORD EXECUTORCH_MAVEN_CENTRAL_USERNAME EXECUTORCH_MAVEN_SIGNING_GPG_KEY_CONTENTS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably need line 46 and 48 from https://github.com/pytorch/executorch/blob/main/.github/workflows/apple.yml#L46-L48 too

    if: ${{ !github.event.pull_request.head.repo.fork }}
    secrets: inherit

huydhn
huydhn reviewed Apr 7, 2025
View reviewed changes
.github/workflows/android-release-artifacts.yml
@@ -52,6 +55,16 @@ jobs:
PYTHON_EXECUTABLE=python bash .ci/scripts/setup-linux.sh --build-tool buck2
export ARTIFACTS_DIR_NAME=artifacts-to-be-uploaded

mkdir -p ~/.gradle
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious if these secrets can be used after building the aar archive, or do they need to be set in gradle.properties before the build?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the build, before publish in here: https://github.com/pytorch/executorch/pull/9787/files#diff-bb64d4a0ad63db311f02484469ec3e9c1fc264c8fe6c3e190ec962348af963b3R129

This PR is WIP, and will fix afterwards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huydhn huydhn huydhn left review comments

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kirklandsign @huydhn @facebook-github-bot